[UI tests] remove parallel commands in test #27579
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Monkeychip
added
ui
pr/no-changelog
backport/ent/1.16.x+ent
github-actions
bot
added
the
hashicorp-contributed-pr
|
Build Results: |
|
CI Results: |
Monkeychip
commented
Jun 24, 2024
| @@ -31,10 +31,10 @@ | |||
| "start:chroot": "ember server --proxy=http://127.0.0.1:8300 --port=4300", | |||
| "test": "concurrently --kill-others-on-fail -P -c \"auto\" -n lint:js,lint:hbs,vault \"yarn:lint:js:quiet\" \"yarn:lint:hbs:quiet\" \"node scripts/start-vault.js {@}\" --", | |||
| "test:enos": "concurrently --kill-others-on-fail -P -c \"auto\" -n lint:js,lint:hbs,enos \"yarn:lint:js:quiet\" \"yarn:lint:hbs:quiet\" \"node scripts/enos-test-ember.js {@}\" --", | |||
| "test:oss": "yarn run test -f='!enterprise' --split=8 --preserve-test-name --parallel", | |||
| "test:oss": "yarn run test -f='!enterprise'", | |||
There was a problem hiding this comment.
note: even on main test:oss does not work. not addressing here, but linting problems with yarn run test. Probably needs to be yarn run test:filter -f
| @@ -31,10 +31,10 @@ | |||
| "start:chroot": "ember server --proxy=http://127.0.0.1:8300 --port=4300", | |||
| "test": "concurrently --kill-others-on-fail -P -c \"auto\" -n lint:js,lint:hbs,vault \"yarn:lint:js:quiet\" \"yarn:lint:hbs:quiet\" \"node scripts/start-vault.js {@}\" --", | |||
There was a problem hiding this comment.
I think this is the command we need to change if this is what's failing on enterprise
Comment on lines
+36
to
+37
| "test:quick": "node scripts/start-vault.js", | ||
| "test:quick-oss": "node scripts/start-vault.js -f='!enterprise'", |
There was a problem hiding this comment.
I don't think we want/need to update these commands
Comment on lines
+36
to
+37
| "test:quick": "node scripts/start-vault.js", | ||
| "test:quick-oss": "node scripts/start-vault.js -f='!enterprise'", |
There was a problem hiding this comment.
I don't think we want/need to update these commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr removes the
--split=8 --preserve-test-name --parallel"commands added onto the test suites. We've been hitting consistently failing test in OIDC/KMIP etc only when we run the tests in parallel. For now, we are removing this line and will revisit for the next release cycle.These commands were added in PR #24669
TODO only if you're a HashiCorp employee
getting backported to N-2, use the new style
backport/ent/x.x.x+entlabelsinstead of the old style
backport/x.x.xlabels.the normal
backport/x.x.xlabel (there should be only 1).of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.