Clone policy permissions and then use existing values rather than policy values for modifications #2826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
values for modifications. Should fix #2804
jefferai
changed the title
vishalnayak
reviewed
Jun 7, 2017
| } | ||
|
|
||
| switch { | ||
| case p.AllowedParameters == nil: |
There was a problem hiding this comment.
Jeff why do we need both a nil check and a len == 0 check, Can you please add a comment to help understand it?
There was a problem hiding this comment.
This makes sure that the clone is an exact clone. A map of length 0 is an empty map, but not the same as a nil (unallocated) map.
briankassouf
reviewed
Jun 7, 2017
| case len(p.AllowedParameters) == 0: | ||
| ret.AllowedParameters = make(map[string][]interface{}) | ||
| default: | ||
| clonedAllowed, err := copystructure.Copy(p.AllowedParameters) |
There was a problem hiding this comment.
Copy structure might cover the above case as well?
There was a problem hiding this comment.
Yes, just doing this for efficiency rather than call into it!
briankassouf
approved these changes
Jun 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #2804
Note: this may have some performance impact, although how much will depend on whether there is allowed_parameters/denied_parameters. We may be able to speed that up, but at the moment I'm preferring correctness over speed.