Switch policies in AppRole to TypeCommaStringSlice #3163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishalnayak
reviewed
Aug 14, 2017
helper/policyutil/policyutil.go
Outdated
| } | ||
| policies = strings.Split(policiesRaw, ",") | ||
| case []string: | ||
| policies = policiesRaw.([]string) |
There was a problem hiding this comment.
If an empty string is supplied as policies, do we want to add the default policy?
There was a problem hiding this comment.
We don't do it here and I'm afraid things will break (especially, in the token store). We already have defaults in approle's schema.
vishalnayak
approved these changes
Aug 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3147