Various PKI updates #3953
Merged
Various PKI updates #3953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update hostname regex in cert util to handle wildcard * Convert a DNS name, if needed, to IDN equivalent before adding to DNS SANs (wildcard handled separately since it is not a valid part of an IDNA conversion) * Change SAN DNS value in tests to be host names since Go 1.10 will be more strict about this
chrishoffman
previously approved these changes
Feb 9, 2018
only take effect when it actually produces new output so it can't be relied upon to ensure that only DNS-compatible names get through.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SANs (wildcard handled separately since it is not a valid part of an
IDNA conversion)
more strict about this