Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap storage calls with encoding checks #5819

Merged
merged 6 commits into from Nov 19, 2018
Merged

Wrap storage calls with encoding checks #5819

merged 6 commits into from Nov 19, 2018

Conversation

briankassouf
Copy link
Member

No description provided.

@briankassouf briankassouf added this to the 1.0 milestone Nov 19, 2018
@tyrannosaurus-becks
Copy link
Contributor

There's a test failure that looks related:

--- FAIL: TestHandler_nonPrintableChars (0.04s)
    handler_test.go:665: Expected status 204, got 500. Body:
        
        {"errors":["1 error occurred:\n\t* failed to write: key contains non-printable characters\n\n"]}

calvn
calvn previously approved these changes Nov 19, 2018
@briankassouf briankassouf merged commit 9e2111e into master Nov 19, 2018
@briankassouf briankassouf deleted the key-encoding branch November 19, 2018 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants