UI - fix perf standby feature display #5971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meirish
force-pushed
the
ui-perf-standby
branch
from
d22494c
to
b3a1253
Compare
madalynrose
previously approved these changes
Dec 18, 2018
| @@ -71,7 +71,8 @@ | |||
| {{#each featuresInfo as |info|}} | |||
| {{#info-table-row label=info.name value=(if info.active "Active" "Not Active") data-test-feature-row="data-test-feature-row"}} | |||
| {{#if info.active}} | |||
| <ICon @size=28 @glyph="true" /> <span data-test-feature-status>Active</span> | |||
| <ICon @size=28 @glyph="true" /> <span data-test-feature-status>Active {{#if info.count}}— | |||
joshuaogle
reviewed
Dec 18, 2018
Co-Authored-By: meirish <meirish@users.noreply.github.com>
|
|
joshuaogle
approved these changes
Dec 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perf standbys are always in the features list (in pro and prem), but there's also
performance_standby_countwhich is 0 in pro and 2 in prem. This PR changes the license component to display count if there is one, and to show Performance Standby as Not Active if the count is 0.