Fixed ignored empty value set on token role update call #6314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefferai
reviewed
Mar 1, 2019
|
Looks good -- there is/are a/some token store role tests that test out role CRUD operations, it would be good to update those tests to ensure correct behavior (so that we'll also detect regressions). |
michelvocks
force-pushed
the
fix_token_role_update_param_reset
branch
2 times, most recently
from
24c50c7
to
19749e7
Compare
michelvocks
force-pushed
the
fix_token_role_update_param_reset
branch
from
19749e7
to
b301ead
Compare
jefferai
approved these changes
Mar 4, 2019
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6296