Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI transit date fix #6827

Merged
merged 2 commits into from Jun 20, 2019
Merged

UI transit date fix #6827

merged 2 commits into from Jun 20, 2019

Conversation

meirish
Copy link
Contributor

@meirish meirish commented Jun 4, 2019

Dates for transit keys that are timestamps come from the api as seconds - this is true for aes256-gcm96 and chacha20-poly1305 type keys. Our date helpers expect input as either a date time string or milliseconds - so we now transform the appropriate responses in the serializer to convert seconds to milliseconds.

@meirish meirish requested a review from a team June 4, 2019 22:42
@meirish meirish merged commit a0f3249 into master Jun 20, 2019
@meirish meirish deleted the ui-transit-date branch June 20, 2019 13:39
@meirish meirish added this to the 1.2 milestone Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants