kv v2 display bugs #7307
Merged
kv v2 display bugs #7307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noelledaley
approved these changes
Aug 13, 2019
meirish
added a commit
that referenced
this pull request
Aug 13, 2019
* fix switch css * allow breadcrumbs container to grow if it's overflowed so that it's still usable * close the dropdowns on destructive actions that cause a route refresh * use new attachCapabilities for context menus on auth methods to get rid of an error
meirish
added a commit
that referenced
this pull request
Aug 14, 2019
* fix switch css * allow breadcrumbs container to grow if it's overflowed so that it's still usable * close the dropdowns on destructive actions that cause a route refresh * use new attachCapabilities for context menus on auth methods to get rid of an error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a handful of small visual bugs, most of them related to KV V2. The fixes include:
Styling the toggle switches,
The breadcrumbs overflow in KVv2:
First: the overflow for the breadcrumbs on OSX meant that the clickable area was really small:
It now looks like this:
Dropdowns in KVv2 would cause errors because the page would refresh but the dropdown would still be rendered, so they are now explicitly closed when it's a destructive action that happens. They previously were functional but the rendering wasn't great and the ui would get "stuck".
Context menus in the auth method list would throw an error if you went to the configuration page, then back to the list and tried clicking again. Moving to a newer style for capabilities where they are ember data relationships has fixed this issue.