Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump golang to v1.13.4 #7891

Closed
wants to merge 1 commit into from
Closed

Bump golang to v1.13.4 #7891

wants to merge 1 commit into from

Conversation

chenrui333
Copy link

@chenrui333 chenrui333 commented Nov 16, 2019 •
edited

Relates to #7879

@chenrui333 chenrui333 changed the title Go 1.12.13 Bump golang to v1.12.13 Nov 16, 2019
@chenrui333 chenrui333 mentioned this pull request Nov 16, 2019
Closed
@jefferai
Copy link
Member

Please undo the tidy change. Go 1.12 keeps adding it back at build and dirtying the tree so for now we're leaving it in. Note that we're moving to Go 1.13 anytime now.

@chenrui333
Copy link
Author

Sure, reverting it now.

@samsalisbury
Copy link
Contributor

Hi @chenrui333 this is failing due to whitespace differences in the generated .circleci/config.yml can I ask what version of the CircleCI CLI you have installed locally? Also what OS are you using? I have pushed a change to master that ignores whitespace diffs in the ci-verify step, so if you rebase your changes on that, delete the .circleci/.tmp directory, and then re-run make ci-config and force-push it all to this branch, we should see the CI pipeline run beyond the pre-flight-checks, thanks.

samsalisbury
samsalisbury reviewed Nov 21, 2019
View reviewed changes
Copy link
Contributor

@samsalisbury samsalisbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment: #7891 (comment)

@jefferai
Copy link
Member

Master is now 1.4 dev train so we need to go to 1.13.4.

jefferai
jefferai requested changes Nov 21, 2019
View reviewed changes
Copy link
Member

@jefferai jefferai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs update

@chenrui333 chenrui333 changed the title Bump golang to v1.12.13 Bump golang to v1.13.4 Nov 26, 2019
@chenrui333
Copy link
Author

chenrui333 commented Nov 26, 2019 •
edited

@samsalisbury should be all set (check with make ci-config)

@jefferai Updated the branch to golang v1.13.4.

@chenrui333 chenrui333 closed this Mar 24, 2020
@chenrui333
Copy link
Author

Looks like this is way obsolete, closed the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsalisbury samsalisbury samsalisbury left review comments

@jefferai jefferai jefferai requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chenrui333 @jefferai @samsalisbury