Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add context to website-docker-image job #8272

Merged
merged 3 commits into from
Feb 3, 2020

Conversation

calvn
Copy link
Member

@calvn calvn commented Jan 31, 2020

Provider CircleCI context values to inject env vars for docker login in here:

docker login -u $WEBSITE_DOCKER_USER -p $WEBSITE_DOCKER_PASS

kalafut
kalafut previously approved these changes Jan 31, 2020
Copy link
Contributor

@samsalisbury samsalisbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@calvn calvn merged commit 620ae8b into master Feb 3, 2020
@calvn calvn deleted the ci-ctx-website-docker-image branch February 3, 2020 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants