Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui/add transit modal #8482

Closed
wants to merge 78 commits into from
Closed

ui/add transit modal #8482

wants to merge 78 commits into from

Conversation

noelledaley
Copy link
Contributor

@noelledaley noelledaley commented Mar 5, 2020 •
edited

Move Transit Actions into Modals

This PR contains the last portion of the Transit UX improvements. It includes moving the results of transit key actions into a modal instead of on the page.

For example:
[insert gifs here]

Testing

Using the Transit Learn Docs as a guide, verify that you can perform each key action (encrypt, decrypt, HMAC, etc), as well as copy and paste the results of the text.

TODO:

  • update css so modal body matches design mocks
  • fix key action descriptions so they don't have a border
  • ensure flash messages on successful action matches mocks
  • ensure flash messages when copying from the copy icon matches mocks
  • make flash message when copy & closing less generic
  • get rid of modal X button
  • ensure modal headers match mocks
  • add copy button icons to all pages
  • update verified modal
  • convert export key textarea to codemirror
  • add modal for sign action
  • add modal for export action
  • fix case in export action, where 'wrap' response isn't selected, modal doesn't show the response
  • add note that plaintext is in base64 format
  • update JSDOC comments
  • fix formatting on export > not 'wrapped' modal response
  • fix tests
  • only render modals when isModalActive is true modal already has display: none which doesn't interfere with screen readers

@noelledaley noelledaley added the ui label Mar 5, 2020
noelledaley and others added 19 commits March 5, 2020 15:42
@noelledaley
separate copy ciphertext, plaintext, and close button on datakey modal
2874dc3
@noelledaley
style ciphertext and plaintext as code
18b755d
@noelledaley
only show separate copy buttons on datakey modal if both outputs are …
d1a82fc 
…shown
@noelledaley
update modal styling
153c291
@noelledaley
Merge branch 'master' of https://github.com/hashicorp/vault into ui/a…
750cc6b 
…dd-transit-modal
@noelledaley
style modal
3044a57
@noelledaley
add descriptions to each key action
fbd7cd7
@noelledaley
remove conditional from hmac modal since we only ever show hmac output
34c8986
@noelledaley
add modal for export key action
f887a98
@noelledaley
make output scroll horizontally with copy button next to it
a1c227d
@noelledaley
escape & in copy and close button, format text output so it scrolls h…
47bca48 
…orizontally
@noelledaley
fix formatting of key action descriptions
9234bfc
@chelshaw
Ui/add transit modal tests (#8523)
bcccc75 
* Fix tests for updated transit with modals workflow
@chelshaw
WIP // remove box shadow from key actions descriptions
6c01b31
@chelshaw
WIP // flash messages on successful action match mocks
609244c
@chelshaw
WIP // remove ciphertext view after datakey created
4dd37b2
@chelshaw
WIP // make flash messages when copy & closing less generic, and matc…
3cd6982 
…h copy flash message
@chelshaw
WIP // Optionally show close button on modal, with tests
25e2492
@chelshaw
remove unused deps from modal test
929a95a
Jim Kalafut and others added 16 commits March 13, 2020 10:43
@noelledaley
Update JWT docs (#8513)
ff37b62 
Add mention of new CLI parameters.
@noelledaley
Update LDAP docs for anonymous_group_search (#8501)
43cd4fa
@Monkeychip @noelledaley
remove duplicate form inputs for the github config (#8519)
4037035
@Monkeychip @noelledaley
Update CHANGELOG.md
8a62d5d
@ncabatoff @noelledaley
Add option to detect deadlocks in Core.stateLock using build tag `dea…
c4033ae 
…dlock` (#8524)
@jefferai @noelledaley
Remove misleading comment
35c27c3
@spangenberg @michelvocks @noelledaley
Fix SRV Lookups (#8520)
03ac60f 
* Pin HTTP Host header for all client requests
* Drop port map scheme
* Add SRV Lookup environment var
* Lookup SRV records only when env var is specified
* Add docs

Co-Authored-By: Michel Vocks <michelvocks@gmail.com>
@Monkeychip @noelledaley
Bug Fix: capitalization of HMAC consistency on transit engine (#8528)
e9d17d1 
* upper case the transit form title for hmac

* uppercase hmac for tab

* fix indentation
@Monkeychip @noelledaley
Update CHANGELOG.md
5a38dc9
@calvn @noelledaley
website: update readme with known issues (#8539)
53de013 
* website: update readme with known issues

* website: typo fix

* website: typo fix

* website: wrap text for better readability
@spangenberg @noelledaley
Update CHANGELOG.md
e7429ce 
Add missing link
@jefferai @jescalan @noelledaley
Remove the versus section on the website. (#8538)
b0ab979 
* Remove the versus section on the website.

We don't keep it maintained, it's very out of date, and we don't really
like comparing ourselves to other software anyways; it's not fair to
describe other software or solutions in ways that may not align with
how they want to be described.

Co-authored-by: Jeff Escalante <jescalan@users.noreply.github.com>
@tam7t @noelledaley
stackdriver: metric label extraction (#8073)
e0b4e4e 
* stackdriver: use label extraction and add debug config

* go.mod: update go-metrics-stackdriver

* vendor go-metrics-stackdriver
@michelvocks @noelledaley
changelog++
a4deeac
@sethvargo @noelledaley
Fix Spanner metrics (#8541)
4f0a872 
* Fix metric for Get

This was incorrectly being reported as List

* Measure transactions
@ncabatoff @noelledaley
Add a note about http_max_conns_per_client. (#8344)
5cfb64b
@noelledaley noelledaley marked this pull request as ready for review March 13, 2020 16:49
Monkeychip
Monkeychip requested changes Mar 13, 2020
View reviewed changes
Copy link
Contributor

@Monkeychip Monkeychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I know you're still working on some things, but I QA'd a bit and things worked as expected. Nice work.

ui/app/components/transit-key-actions.js Outdated Show resolved Hide resolved
ui/app/templates/components/transit-key-action/verify.hbs Outdated Show resolved Hide resolved
chelshaw
chelshaw approved these changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@chelshaw chelshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through all the changes carefully and didn't see any red flags. I think it looks good to go!

@noelledaley noelledaley mentioned this pull request Mar 16, 2020
Merged
@chelshaw chelshaw deleted the ui/add-transit-modal branch March 24, 2020 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Monkeychip Monkeychip Monkeychip requested changes

@chelshaw chelshaw chelshaw approved these changes

Assignees
No one assigned
Labels
ui
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.

None yet