Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 1.4.x: Always pick us-east-1 for the "aws" partition #8680

Merged
merged 1 commit into from Apr 9, 2020

Conversation

tyrannosaurus-becks
Copy link
Contributor

This PR backports #8679 to include it in our next Vault release.

* always pick us-east-1 for aws partition

* Update builtin/credential/aws/backend.go

Co-Authored-By: Jim Kalafut <jkalafut@hashicorp.com>

Co-authored-by: Jim Kalafut <jkalafut@hashicorp.com>
@tyrannosaurus-becks tyrannosaurus-becks added this to the 1.4.1 milestone Apr 3, 2020
@tyrannosaurus-becks tyrannosaurus-becks added bug Used to indicate a potential bug auth/aws labels Apr 3, 2020
Copy link
Member

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tyrannosaurus-becks tyrannosaurus-becks merged commit 882a39e into release/1.4.x Apr 9, 2020
@tyrannosaurus-becks tyrannosaurus-becks deleted the backport-pr-8679-1.4.x branch April 9, 2020 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auth/aws bug Used to indicate a potential bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants