Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidebranch: component and acceptance tests #8903

Merged
merged 38 commits into from
May 7, 2020
Merged

Sidebranch: component and acceptance tests #8903

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
40e2636
address secondary card overflow issue
Monkeychip Apr 29, 2020
ac8a859
setup replicaiton header test
Monkeychip Apr 29, 2020
5099118
address secondary card overflow issue
Monkeychip Apr 29, 2020
cc07e0d
setup replication secondary card test
Monkeychip Apr 29, 2020
eccfbf7
setup replicaiton header test
Monkeychip Apr 29, 2020
5f4204b
setup replicaiton page test
Monkeychip Apr 29, 2020
1af6828
setup replication secondary card test
Monkeychip Apr 29, 2020
e8961e5
setup replication dashboard test
Monkeychip Apr 29, 2020
d4988f8
setup replicaiton page test
Monkeychip Apr 29, 2020
4d73d53
remove unused code
Monkeychip Apr 29, 2020
b4a6f10
fix overflow
Monkeychip Apr 29, 2020
fe598c9
finish test for rep dashboard
Monkeychip Apr 30, 2020
fe75932
update rep secondary card test
Monkeychip Apr 30, 2020
7711ef2
finish rep header test
Monkeychip Apr 30, 2020
46bc438
fix rep table rows and header test
Monkeychip Apr 30, 2020
06a01e0
fix header test
Monkeychip Apr 30, 2020
83b0d00
fix missing data-test-primary-cluster
Monkeychip Apr 30, 2020
2dbf648
add to secondary test
Monkeychip May 1, 2020
67a9e12
remove pauseTest
Monkeychip May 1, 2020
b8c6eab
add to enterprise replication test
Monkeychip May 1, 2020
0dd8565
add mode to dr secondary test
Monkeychip May 1, 2020
dc82f7c
remove pauseTest
Monkeychip May 1, 2020
2a13177
add enterprise to test
Monkeychip May 4, 2020
2e63a22
amend per pr commments
Monkeychip May 6, 2020
cd4d33e
re organize rep secondary card test
Monkeychip May 6, 2020
8ef20d2
adjust error heights with design input
Monkeychip May 6, 2020
6d8b6ea
move const around in rep secondary card test
Monkeychip May 6, 2020
4c2cc33
move const around and message for rep dashboard test
Monkeychip May 6, 2020
fb4e4d3
amend per pr review comments
Monkeychip May 6, 2020
836b582
remove styling from grid-item-left
Monkeychip May 6, 2020
a828256
Merge branch 'ui/replication-status-discoverability' into ui/tests-v2
Monkeychip May 6, 2020
83e0cc9
remove dup hasErrorClass key
Monkeychip May 6, 2020
c62814e
Merge branch 'ui/tests-v2' of github.com:hashicorp/vault into ui/test…
Monkeychip May 6, 2020
cff715f
quick fix
Monkeychip May 6, 2020
3d7d01b
test failure fix
Monkeychip May 6, 2020
50955f5
fix test due to merge
Monkeychip May 6, 2020
6b37e6c
remove hasErrorClass
Monkeychip May 6, 2020
6cc801b
modify test message
Monkeychip May 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion ui/lib/core/addon/components/replication-secondary-card.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ export default Component.extend({
layout,
title: null,
replicationDetails: null,
hasErrorClass: false,
state: computed('replicationDetails', function() {
return this.replicationDetails && this.replicationDetails.state
? this.replicationDetails.state
Expand Down
4 changes: 2 additions & 2 deletions ui/tests/integration/components/replication-secondary-card-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ module('Integration | Enterprise | Component | replication-secondary-card', func
test('it renders hasErrorMessage when state is idle', async function(assert) {
this.set('stateError', STATE_ERROR);
await render(
hbs`<ReplicationSecondaryCard @replicationDetails={{stateError}} @title={{title}} @hasErrorClass={{true}}>`
hbs`<ReplicationSecondaryCard @replicationDetails={{stateError}} @title={{title}} @hasErrorClass={{true}} />`
Monkeychip marked this conversation as resolved.
Show resolved Hide resolved
);
assert.dom('[data-test-error]').includesText('state', 'show correct error title');
assert
Expand All @@ -80,7 +80,7 @@ module('Integration | Enterprise | Component | replication-secondary-card', func
test('it renders hasErrorMessage when connection is transient_failure', async function(assert) {
this.set('connectionError', CONNECTION_ERROR);
await render(
hbs`<ReplicationSecondaryCard @replicationDetails={{connectionError}} @title={{title}} @hasErrorClass={{true}}/>`
hbs`<ReplicationSecondaryCard @replicationDetails={{connectionError}} @title={{title}} @hasErrorClass={{true}} />`
);
assert.dom('[data-test-error]').includesText('connection_state', 'show correct error title');
assert
Expand Down