Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

list/map variable type syntax highlighting #610

Closed
frittsy opened this issue Apr 22, 2021 · 3 comments · Fixed by #918
Closed

list/map variable type syntax highlighting #610

frittsy opened this issue Apr 22, 2021 · 3 comments · Fixed by #918
Assignees
Labels
bug Something isn't working syntax

Comments

@frittsy
Copy link

frittsy commented Apr 22, 2021

While I know the list and map functions were officially removed in v0.15.0, they are still valid types for variables and should not be highlighted as red, as shown below. I believe this was broken in #604.
Screen Shot 2021-04-22 at 8 02 55 AM

@radeksimko radeksimko added syntax bug Something isn't working labels Apr 22, 2021
@frittsy
Copy link
Author

frittsy commented Apr 23, 2021

I can take a stab at fixing this, but not sure if it would be better to simply add these as additional types to terraform_type_keywords, or if there needs to be something more akin to structural_types but for all the collection types.

@dbanck
Copy link
Member

dbanck commented Feb 1, 2022

Thanks for the report. I'm able to reproduce this behavior.

list() is always highlighted as invalid.deprecated.terraform even if it's a valid type in variable blocks.
CleanShot 2022-02-01 at 15 05 39@2x

The red color should only be applied in a function-call context.
CleanShot 2022-02-01 at 15 06 29@2x

@github-actions
Copy link

github-actions bot commented Mar 7, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working syntax
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants