Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update list/map syntax highlighting #918

Merged
merged 2 commits into from
Feb 4, 2022
Merged

Update list/map syntax highlighting #918

merged 2 commits into from
Feb 4, 2022

Conversation

dbanck
Copy link
Member

@dbanck dbanck commented Feb 3, 2022

This PR updates the syntax highlighting for the deprecated list() and map() functions.

Closes #610

jpogran
jpogran requested changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@jpogran jpogran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize this is still WIP, but can you please add more descriptive text to the commit message detailing why we're removing this? Just trying to help future us.

I can add if you prefer.

@dbanck
Remove the red highlighting of map and list
8e000ba 
While Terraform v0.15.0 removed the list and map functions, they are still valid types for variables and should not be highlighted as red.
@dbanck
Add map and list to build-in function calls
47e937f 
As we don't know which Terraform version a user uses, the grammar should provide good coverage for all versions.
`list` and `map` were valid function calls for Terraform < v0.15.0, so we'll keep them as highlighted as one.
@dbanck dbanck marked this pull request as ready for review February 4, 2022 11:32
@dbanck dbanck requested a review from a team February 4, 2022 11:32
jpogran
jpogran approved these changes Feb 4, 2022
View reviewed changes
Copy link
Contributor

@jpogran jpogran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the added detail!

@jpogran jpogran added the bug Something isn't working label Feb 4, 2022
@dbanck dbanck merged commit 38fa1f9 into main Feb 4, 2022
@dbanck dbanck deleted the bug-listmap-syntax branch February 4, 2022 15:12
@jpogran jpogran added this to the 2.20.0 milestone Feb 18, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jpogran jpogran jpogran approved these changes

@radeksimko radeksimko radeksimko approved these changes

Assignees

@dbanck dbanck

Labels
bug Something isn't working
Projects
None yet
Milestone
2.20.0
Development

Successfully merging this pull request may close these issues.

list/map variable type syntax highlighting
3 participants
@dbanck @jpogran @radeksimko