Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing highlighting for nested for expressions #926

Closed
dbanck opened this issue Feb 8, 2022 · 2 comments · Fixed by #940
Closed

Missing highlighting for nested for expressions #926

dbanck opened this issue Feb 8, 2022 · 2 comments · Fixed by #940
Assignees
Labels
bug Something isn't working syntax

Comments

@dbanck
Copy link
Member

dbanck commented Feb 8, 2022

The syntax highlighting for for expressions currently only works if they start with a [ or { in the same line.

When using a for expression for filtering elements, the expression is not highlighted correctly.

CleanShot 2022-02-08 at 17 51 18

@dbanck dbanck added bug Something isn't working syntax labels Feb 8, 2022
@radeksimko
Copy link
Member

Just for clarification - as I wasn't sure about this myself - the tokens in the expression are exactly the same in both cases, there's just extra newline. In other words the { and } are still considered as part of the for expression even if they're on separate lines.

See https://go.dev/play/p/m13bKnvCLpt

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working syntax
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants