Fix highlighting for nested expression syntax #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since all regular expressions used in grammar match rules must apply to a single line at a time, we can't reuse the existing `for` patterns. New patterns are in included in the brackets and objects patterns to match `for` and `if` statements.
dbanck
force-pushed
the
bug-nested-expression-syntax
branch
from
c3e36be
to
e599d9b
Compare
radeksimko
approved these changes
Feb 22, 2022
jpogran
approved these changes
Feb 22, 2022
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for nested expressions.
Since all regular expressions used in grammar match rules must apply to a single line at a time, we can't reuse the existing
forpatterns. So instead, new patterns are added to the brackets and objects patterns to matchforandifstatements.UX Change
Before
After
Closes #926