Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download syntax #1004

Merged
merged 5 commits into from
Mar 21, 2022
Merged

Download syntax #1004

merged 5 commits into from
Mar 21, 2022

Conversation

jpogran
Copy link
Contributor

@jpogran jpogran commented Mar 21, 2022 •
edited
Loading

This downloads the specified version of hashicorp/syntax on build or package.

This also removes all syntax testing from this extension, as it is handled in the hashicorp/syntax repo.

@jpogran jpogran self-assigned this Mar 21, 2022
@jpogran jpogran added the ci Continuous integration/delivery related label Mar 21, 2022
@jpogran jpogran added this to the 2.21.0 milestone Mar 21, 2022
@jpogran jpogran linked an issue Mar 21, 2022 that may be closed by this pull request
Download grammar file from hashicorp/syntax on build #997
Closed
@jpogran jpogran marked this pull request as ready for review March 21, 2022 14:33
radeksimko
radeksimko reviewed Mar 21, 2022
View reviewed changes
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one pending question in-line, otherwise LGTM.

build/downloader.ts Show resolved Hide resolved
build/downloader.ts Outdated Show resolved Hide resolved
dbanck
dbanck requested changes Mar 21, 2022
View reviewed changes
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup!

We need to update the scopeName in package.json from source.terraform to source.hcl.terraform to make the new grammar work.

package.json Show resolved Hide resolved
radeksimko
radeksimko approved these changes Mar 21, 2022
View reviewed changes
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

dbanck
dbanck approved these changes Mar 21, 2022
View reviewed changes
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jpogran jpogran merged commit b17312b into main Mar 21, 2022
@jpogran jpogran deleted the download_syntaxes branch March 21, 2022 15:32
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dbanck dbanck dbanck approved these changes

@radeksimko radeksimko radeksimko approved these changes

Assignees

@jpogran jpogran

Labels
ci Continuous integration/delivery related
Projects
None yet
Milestone
v2.21.0
Development

Successfully merging this pull request may close these issues.

Download grammar file from hashicorp/syntax on build
3 participants
@jpogran @dbanck @radeksimko