Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update initializationOptions per recent LS changes #1193

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Jul 27, 2022

This is to reflect last changes from the following PRs in the extension settings:


The user-facing changes here are:

  1. Updated deprecation message to rootModulePaths to reflect that this option is going away for good and nudge users to add folders to the workspace instead.
  2. New indexing config subsection for indexer-related options.

terraform options are already aligned with LS, so that's just internal change.

@radeksimko radeksimko added the enhancement New feature or request label Jul 27, 2022
@radeksimko radeksimko self-assigned this Jul 27, 2022
@radeksimko radeksimko added this to the v2.24.0 milestone Jul 27, 2022
@radeksimko radeksimko marked this pull request as ready for review July 27, 2022 14:27
@radeksimko radeksimko requested a review from a team as a code owner July 27, 2022 14:27
Copy link
Contributor

@jpogran jpogran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@radeksimko radeksimko merged commit 780c803 into main Jul 27, 2022
@radeksimko radeksimko deleted the f-update-init-options branch July 27, 2022 14:41
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants