Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix enable terraform-ls after disabling #1238

Merged
merged 1 commit into from
Sep 21, 2022
Merged

Conversation

jpogran
Copy link
Contributor

@jpogran jpogran commented Sep 19, 2022

This commit ensures all commands that control terraform-ls are registered regardles of whether or not terraform-ls is enabled. This allows the when clauses to work appropriately but still have the commands registered.

@jpogran jpogran self-assigned this Sep 19, 2022
@jpogran jpogran linked an issue Sep 19, 2022 that may be closed by this pull request
@jpogran jpogran added the bug Something isn't working label Sep 19, 2022
This commit ensures all commands that control terraform-ls are registered regardles of whether or not terraform-ls is enabled. This allows the when clauses to work appropriately but still have the commands registered.
@jpogran jpogran marked this pull request as ready for review September 19, 2022 12:35
@jpogran jpogran requested a review from a team as a code owner September 19, 2022 12:35
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jpogran jpogran merged commit 69695d4 into main Sep 21, 2022
@jpogran jpogran deleted the gh-1232-fix-enable-ls branch September 21, 2022 13:54
@jpogran jpogran changed the title Fix enable terraform-ls after disbaling Fix enable terraform-ls after disabling Oct 13, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Command "Enable Language Server" doesn't work
2 participants