Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboard to pre-release extensions #1412

Merged
merged 9 commits into from
May 4, 2023
Merged

Onboard to pre-release extensions #1412

merged 9 commits into from
May 4, 2023

Conversation

dbanck
Copy link
Member

@dbanck dbanck commented May 3, 2023

Running the ./build/preview script will now only update the version (and LS version if supplied):

-  "version": "2.26.0",
+  "version": "2.26.2023050315",

We supply the --pre-release to vsce package and vsce publish as outlined here.

@dbanck dbanck self-assigned this May 3, 2023
Copy link
Contributor

@jpogran jpogran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dbanck added 2 commits May 3, 2023 15:48
The new pre-releases extensions function only allows one
extension to be installed at a time.
@dbanck dbanck marked this pull request as ready for review May 3, 2023 13:49
@dbanck dbanck requested a review from a team as a code owner May 3, 2023 13:49
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, my only nit-picky note which is less related to the diff/PR is that shell scripts like build/preview typically have an extension like *.sh or *.bash.

build/preview Show resolved Hide resolved
@dbanck dbanck merged commit 3803c1d into main May 4, 2023
17 checks passed
@dbanck dbanck deleted the c-prerelease-pipeline branch May 4, 2023 12:37
@github-actions
Copy link

github-actions bot commented Jun 4, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants