Install Refactor

[appilon]

This refactor flattens the code as much as possible and fixes an install bug. The conversion did lose one cleanup task (deleting the zip on error), will try and restore that later.

[radeksimko]

My recent JS/TS experience is rusty, as you know, but the code LGTM.

I just noticed that the code may need formatting:

vscode-terraform/src/languageServerInstaller.ts

Lines 126 to 127 in 564503c

	.on('error', reject)
	.end();

vscode-terraform/src/languageServerInstaller.ts

Line 218 in 564503c

.on('end', () => resolve(body));

Also weirdly when I attempt to launch it locally I get the following error - unsure what's the cause:

[appilon]

@radeksimko the formatting is Alex Pilon flavoured javascript, I like to indent and align chained methods, I find helps keep track of what "layer" you are in once you start putting callbacks everywhere. I will run the vscode formatter but I don't think it will correct that (javascript does not have strict formatting best practices like Go... sadly).

EDIT: AH I see it does look funny, for some reason that's my editor doing that...

As for the error I have never seen that, what are your repro steps? I will see if I can get that error.

[appilon]

@radeksimko I am able to reproduce that error message now

[appilon]

@radeksimko fixed!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the context necessary to investigate further.