Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement opt out config option for ref count code lens #837

Merged
merged 1 commit into from
Nov 8, 2021
Merged

Implement opt out config option for ref count code lens #837

merged 1 commit into from
Nov 8, 2021

Conversation

dbanck
Copy link
Member

@dbanck dbanck commented Nov 5, 2021

This PR adds a new setting called enableReferenceCountCodeLens which toggles displaying reference counts above top level blocks and attributes.

Closes #713.

radeksimko
radeksimko approved these changes Nov 8, 2021
View reviewed changes
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

I reckon this may conflict with changes in #834 but hopefully shouldn't be too hard to rebase that PR 🤞🏻

FYI @jpogran

@dbanck dbanck merged commit dd94cfc into main Nov 8, 2021
Terraform Editor Experience Public Roadmap automation moved this from In Progress to Done Nov 8, 2021
@dbanck dbanck deleted the f-713-reference-count-setting branch November 8, 2021 10:10
@github-actions
Copy link

github-actions bot commented Dec 9, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radeksimko radeksimko radeksimko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Terraform Editor Experience Public Ro...
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide opt out config option for ref count code lens
2 participants
@dbanck @radeksimko