Remove public api

[dbanck]

This PR depends on #857, which needs to be merged first.

Our activate function returned moduleCallers and clientHandler which enabled other extensions to use them. We didn't intend this behavior and don't want to expose any public API yet.

See:

https://code.visualstudio.com/api/references/vscode-api#extensions
Extension writers can provide APIs to other extensions by returning their API public surface from the activate call.

This PR removes the return value from activate and refactors the workspaces.spec.ts test, which used this API.

[radeksimko]

Just for context - I believe the original intention behind the public API exposure was testability, but naturally it can be tested as a decoupled unit too, as you have demonstrated here. 👍🏻

I agree with the conservative decision of not exposing any API yet until we know what the consumer needs are. I reckon we'll investigate some use cases as part of #692

[jpogran]

Small suggestion to check for undefined, otherwise approved!

[jpogran]

🚢

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.