Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run syntax tests when grammar changes #922

Merged
merged 3 commits into from
Feb 8, 2022
Merged

Run syntax tests when grammar changes #922

merged 3 commits into from
Feb 8, 2022

Conversation

jpogran
Copy link
Contributor

@jpogran jpogran commented Feb 4, 2022

This runs the syntax tests only if the grammar files change in the syntaxes directory.

As we start to modify the syntax and grammar more, we'll be running tests more frequently. We don't need to incur the cost or time of running the entire suite when we are testing grammar changes.

@jpogran
Run syntax tests when grammar changes
6d88409 
This commit runs the syntax tests only if the grammar files change in the syntaxes directory.
@jpogran jpogran self-assigned this Feb 4, 2022
@jpogran jpogran added ci Continuous integration/delivery related syntax labels Feb 4, 2022
@jpogran jpogran marked this pull request as ready for review February 4, 2022 17:42
@jpogran jpogran requested a review from a team February 4, 2022 17:42
dbanck
dbanck requested changes Feb 7, 2022
View reviewed changes
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be sure: this will still run the main test.yml workflow on each syntax change, as long as we don't exclude the syntax paths in test.yml, right?

.github/workflows/syntax.yml Show resolved Hide resolved
@jpogran
Copy link
Contributor Author

jpogran commented Feb 7, 2022

Good point. This didn't go far enough and prevent test.yml from running when there are just syntax changes

dbanck
dbanck approved these changes Feb 7, 2022
View reviewed changes
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jpogran jpogran merged commit e2766d4 into main Feb 8, 2022
@jpogran jpogran deleted the run_syntax_on_path_change branch February 8, 2022 17:11
@jpogran jpogran added this to the 2.20.0 milestone Feb 18, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dbanck dbanck dbanck approved these changes

Assignees

@jpogran jpogran

Labels
ci Continuous integration/delivery related syntax
Projects
None yet
Milestone
2.20.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jpogran @dbanck