Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

Commit

Permalink
Correct usage of its and it's.
Browse files Browse the repository at this point in the history
Had a few minutes before a meeting, and decided to redeem myself after #2049 (comment)
  • Loading branch information
izaaklauer committed Aug 17, 2021
1 parent d84037c commit 2d9d6d0
Show file tree
Hide file tree
Showing 20 changed files with 23 additions and 23 deletions.
4 changes: 2 additions & 2 deletions ARCHITECTURE.md
Expand Up @@ -269,7 +269,7 @@ goes back to the buffer and gets the current chunk list the buffer points to.
In the diagram above, the purple reader points to the current chunk list
and is almost caught up with the writer. The blue reader points to a past
chunk list that is no longer in use by the writer. If the writer completes
it's full chunk list before the blue reader catches up, then the blue
its full chunk list before the blue reader catches up, then the blue
reader may "skip" a chunk list. This is acceptable to have predictable
memory usage and avoid poorly behaved readers from inflating memory usage
on the system.
Expand Down Expand Up @@ -481,7 +481,7 @@ to execute Waypoint-specific business logic.

Package server implements the Waypoint server and associated helper packages.
This contains the main API implementation and persistent storage implementation.
This package is so important and so large that its useful to dive into the
This package is so important and so large that it's useful to dive into the
sub-packages:

#### `internal/server/ptypes`
Expand Down
2 changes: 1 addition & 1 deletion builtin/aws/lambda/ecs.go
Expand Up @@ -183,7 +183,7 @@ type TaskInfo struct {
// This is the port the ECS task will be listening on.
const sshPort = 2222

// Launch creates the ECS task and returns it's public IP and ARN
// Launch creates the ECS task and returns its public IP and ARN
func (e *ecsLauncher) Launch(
ctx context.Context,
L hclog.Logger,
Expand Down
2 changes: 1 addition & 1 deletion builtin/docker/copy.go
Expand Up @@ -9,7 +9,7 @@ import (

// copyFile copies the contents of the file named src to the file named
// by dst. The file will be created if it does not already exist. If the
// destination file exists, all it's contents will be replaced by the contents
// destination file exists, all its contents will be replaced by the contents
// of the source file. The file mode will be copied from the source and
// the copied data is synced/flushed to stable storage.
func copyFile(src, dst string) (err error) {
Expand Down
2 changes: 1 addition & 1 deletion internal/appconfig/option.go
Expand Up @@ -44,7 +44,7 @@ type FileContent struct {
type UpdatedConfig struct {
// Indicates that EnvVars is what the application should be using. This is an
// explicit flag because EnvVars might be reset to nil, meaning the application
// should remove all it's configuration
// should remove all its configuration
UpdatedEnv bool

// This is the list of env vars in key=value format that the application should
Expand Down
2 changes: 1 addition & 1 deletion internal/cli/base.go
Expand Up @@ -495,7 +495,7 @@ func (c *baseCommand) flagSet(bit flagSetBit, f func(*flag.Sets)) *flag.Sets {
// CLI flags are specified after positional arguments. Since we use the
// stdlib flag package, this is not allowed. However, we can detect this
// scenario, and notify a user. We can't easily automatically fix it because
// its hard to tell positional vs intentional flags.
// it's hard to tell positional vs intentional flags.
func checkFlagsAfterArgs(args []string, set *flag.Sets) error {
if len(args) == 0 {
return nil
Expand Down
2 changes: 1 addition & 1 deletion internal/cli/exec.go
Expand Up @@ -50,7 +50,7 @@ func (c *ExecCommand) targeted(
return ErrSentinel
}

// Ok, the instance id is fine, let's go ahead and have execclient do it's thing.
// Ok, the instance id is fine, let's go ahead and have execclient do its thing.
ec.InstanceId = c.flagInstanceId

return nil
Expand Down
2 changes: 1 addition & 1 deletion internal/cli/runner_agent.go
Expand Up @@ -70,7 +70,7 @@ func (c *RunnerAgentCommand) Run(args []string) int {
c.ui.Output("Runner logs:", terminal.WithHeaderStyle())
c.ui.Output("")

// Set our log output higher if its not already so that it begins showing.
// Set our log output higher if it's not already so that it begins showing.
if !log.IsInfo() {
log.SetLevel(hclog.Info)
}
Expand Down
2 changes: 1 addition & 1 deletion internal/cli/status.go
Expand Up @@ -1098,7 +1098,7 @@ their current state, run ‘waypoint status -app=APP-NAME PROJECT-NAME’.
`)

wpStatusAppSuccessMsg = strings.TrimSpace(`
The application and it's resources listed above represents it's current state known
The application and its resources listed above represents its current state known
in the Waypoint server.
`)

Expand Down
2 changes: 1 addition & 1 deletion internal/client/project.go
Expand Up @@ -34,7 +34,7 @@ type Project struct {

localServer bool // True when a local server is created

// These are used to manage a local runner and it's job processing
// These are used to manage a local runner and its job processing
// in a goroutine.
wg sync.WaitGroup
bg context.Context
Expand Down
2 changes: 1 addition & 1 deletion internal/config/app_config.go
Expand Up @@ -87,7 +87,7 @@ func (c *genericConfig) envVars() ([]*pb.ConfigVar, error) {
// Decode the value
val, diags := pair.Pair.Value.Value(ctx)
if diags.HasErrors() {
// Ok, we can't read it's value right now. Let's do a partial evaluation then.
// Ok, we can't read its value right now. Let's do a partial evaluation then.
str, err := partial.EvalExpression(ctx, pair.Pair.Value)
if err != nil {
return nil, err
Expand Down
2 changes: 1 addition & 1 deletion internal/config/app_config_sort.go
Expand Up @@ -52,7 +52,7 @@ func (c *genericConfig) sortVars(ctx *hcl.EvalContext) ([]*analyzedPair, error)
// https://www.geeksforgeeks.org/topological-sorting-indegree-based-solution/
//
// degrees tracks how many times a variable is referenced.
// pairMap maps a variable's name to it's data.
// pairMap maps a variable's name to its data.
degrees := map[string]int{}
pairMap := map[string]*analyzedPair{}

Expand Down
2 changes: 1 addition & 1 deletion internal/core/operation.go
Expand Up @@ -32,7 +32,7 @@ type operation interface {
// Do performs the actual operation and returns the result that you
// want to return from the operation. This result will be marshaled into
// the ValuePtr if it implements ProtoMarshaler.
// Do can alter the proto.Message into it's final form, as it's the value
// Do can alter the proto.Message into its final form, as it's the value
// returned by Init and that will be written back via Upsert after Do
// has completed.
Do(context.Context, hclog.Logger, *App, proto.Message) (interface{}, error)
Expand Down
2 changes: 1 addition & 1 deletion internal/pkg/copy/copy.go
Expand Up @@ -12,7 +12,7 @@ import (

// CopyFile copies the contents of the file named src to the file named
// by dst. The file will be created if it does not already exist. If the
// destination file exists, all it's contents will be replaced by the contents
// destination file exists, all its contents will be replaced by the contents
// of the source file. The file mode will be copied from the source and
// the copied data is synced/flushed to stable storage.
func CopyFile(src, dst string) (err error) {
Expand Down
2 changes: 1 addition & 1 deletion internal/plugin/invoke.go
Expand Up @@ -13,7 +13,7 @@ import (
"github.com/hashicorp/waypoint-plugin-sdk/internal-shared/protomappers"
)

// PluginRequest describes a plugin that should be setup to have it's functions
// PluginRequest describes a plugin that should be setup to have its functions
// invoked. Config is used to identify the plugin by name, and Type is used to identify
// which one of the plugin types should be addressed within the plugin process.
type PluginRequest struct {
Expand Down
2 changes: 1 addition & 1 deletion internal/runner/accept.go
Expand Up @@ -20,7 +20,7 @@ import (
var heartbeatDuration = 5 * time.Second

// AcceptMany will accept jobs and execute them on after another as they are accepted.
// This is meant to be run in a goroutine and reports it's own errors via r's logger.
// This is meant to be run in a goroutine and reports its own errors via r's logger.
func (r *Runner) AcceptMany(ctx context.Context) {
for {
if err := r.Accept(ctx); err != nil {
Expand Down
4 changes: 2 additions & 2 deletions internal/runner/operation_release.go
Expand Up @@ -33,9 +33,9 @@ func (r *Runner) executeReleaseOp(
// Our target deployment
target := op.Release.Deployment

// Get our last release. If its the same generation, then release is
// Get our last release. If it's the same generation, then release is
// a no-op and return this value. We only do this if we have a generation.
// We SHOULD but if we have an old client, its possible we don't.
// We SHOULD but if we have an old client, it's possible we don't.
var release *pb.Release
if target.Generation != nil {
resp, err := r.client.GetLatestRelease(ctx, &pb.GetLatestReleaseRequest{
Expand Down
2 changes: 1 addition & 1 deletion internal/server/grpc.go
Expand Up @@ -75,7 +75,7 @@ func newGrpcServer(opts *options) (*grpcServer, error) {
func (s *grpcServer) start() error {
// Register the reflection service. This makes using tools like grpcurl
// easier. It makes it slightly easier for malicious users to know about
// the service but I think they'd figure out its a waypoint server
// the service but I think they'd figure out it's a waypoint server
// easy enough.
reflection.Register(s.server)

Expand Down
4 changes: 2 additions & 2 deletions internal/server/singleprocess/service_entrypoint.go
Expand Up @@ -373,10 +373,10 @@ func (s *service) EntrypointExecStream(
sawExit = true
}

// Send the event along. We if the reciever is gone (ie it's context is Done())
// Send the event along. We if the reciever is gone (ie its context is Done())
// then we don't bother. We don't depend on server.Context() here because
// that is done within server.Recv() and we want to allow it to returned buffered
// messages even if it's internal context is Done().
// messages even if its internal context is Done().
select {
case exec.EntrypointEventCh <- req:
// ok
Expand Down
2 changes: 1 addition & 1 deletion internal/server/singleprocess/service_exec.go
Expand Up @@ -137,7 +137,7 @@ func (s *service) StartExecStream(
jobId := qresp.JobId

// Be sure that if we decide things aren't going well, the job doesn't outlive
// it's usefulness.
// its usefulness.
defer s.state.JobCancel(jobId, false)

log.Debug("waiting on job state", "job-id", jobId)
Expand Down
2 changes: 1 addition & 1 deletion x/slack/pkg/bot/ui.go
Expand Up @@ -317,7 +317,7 @@ func (u *uiStep) ReactStatus(status string) {
}

// Called when the step has finished. This must be done otherwise the StepGroup
// will wait forever for it's Steps to finish.
// will wait forever for its Steps to finish.
func (u *uiStep) Done() {
if u.done {
return
Expand Down

0 comments on commit 2d9d6d0

Please sign in to comment.