-
Notifications
You must be signed in to change notification settings - Fork 327
Add support for installing Waypoint server to AWS ECS #1564
Conversation
- Working with dynamic efs - Server installs, runner installs, everything gets destroyed - Upgrade works except for occasional health check problems
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good! Nice job 😄
The other major comment is instead of using lots of Status
outputs, we should use StepGroups for things like this for example:
These messages have green checks but read like Waypoint is still checking on them
✓ Waiting for EFS mount targets to become available...
✓ Installing runner...
Once it becomes available or installed we should update the stepgroup to refresh the line to say the waiting or installing has completed.
Another example, we can combine some of these messages into stepgroups so we aren't printing too much output on install:
✓ Examining existing CloudWatchLogs groups...
✓ Created CloudWatchLogs group to store logs in: waypoint-server-logs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I just ran through the code and left some suggestions around output and flag doc strings. 🎉
Co-authored-by: Brian Cain <bcain@hashicorp.com>
Co-authored-by: Brian Cain <bcain@hashicorp.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
This PR adds initial support for installing the Waypoint server into AWS ECS as a service. The installation borrowed heavily from the previous impelemention of ECS applications created by waypoint, and has a similar architecture.
UX
Infrastructure used
The main components installed are detailed below:
* A Network Load Balancer is required because user-supplied TLS certificates are not yet supported