This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Server/client: Add keepalive to RPC connections #1735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is awesome! Thanks for fixing! We had a similar issue in our environment and our limits were even lower (NGINX's default is 30s IIRC), thus this was causing a lot of disconnections from the runners. We "worked around" the problem by increasing the connection timeout limit, but obviously your proposal is much, much better! |
mitchellh
approved these changes
Jun 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on the environment, certain network load balancers et. al. may terminate idle connections if no activity is detected after some time. EKS specifically uses a classic load balancer for the Waypoint server service and will by default terminate connections after 60s of inactivity. This results in the waypoint runner crash loop shown in #1398.
In this PR we configure keepalive properties on both the server and the client, to maintain the connection even if there is no activity in the stream. I believe these are the only 2 locations where the client is created, but please let me know if I missed on.
*Note: the numbers used here are fairly arbitrary and worked for AWS EKS. The client
Timehas a minimum of 10s. From my testing it needs to be greater than the server enforcement'sMinTime.Fixes #1398