Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

ui: Fix tab styles for dark mode #2053

Merged
merged 2 commits into from
Aug 16, 2021
Merged

ui: Fix tab styles for dark mode #2053

merged 2 commits into from
Aug 16, 2021

Conversation

almonk
Copy link
Contributor

@almonk almonk commented Aug 16, 2021

Fixes the background color and border color of tabs in dark mode

Before
Safari 2021-08-16 at 14 51 00

After
Safari 2021-08-16 at 14 48 37

@almonk almonk requested a review from a team August 16, 2021 13:49
@github-actions github-actions bot added the ui label Aug 16, 2021
Copy link
Contributor

@sabrinako sabrinako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it'd be helpful to submit an issue or PR to the structure library about this, but I'm approving for now!

@almonk
Copy link
Contributor Author

almonk commented Aug 16, 2021

@sabrinako I think you're probably right – I actually don't know the extent to which dark mode is supported by structure currently? cc @Dhaulagiri

@Dhaulagiri
Copy link
Contributor

Not 100% sure but I believe the answer is minimal support if at all. Definitely on our roadmap to improve this in the design system.

@sabrinako sabrinako merged commit 9fb834f into main Aug 16, 2021
@sabrinako sabrinako deleted the ui/fix-tab-hover branch August 16, 2021 16:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants