ui: Logs don’t update when switching between deployments

[jgwhite]

Describe the bug
When switching between deployments in the new UI, the logs do not update.

CleanShot.2021-12-20.at.15.07.43.mp4

Steps to Reproduce

1. Visit the deployment page in Waypoint UI
2. Navigate between deployments
3. Observe the logs do not updae

Expected behavior
The logs should update :)

Waypoint Platform Versions
f620510

[jgwhite]

Research Notes:

@sabrinako and I spent a while figuring out what’s going on here. It turns out that we’re experiencing undesired behavior due to component re-use in combination with “sticky state”. That is to say, when the user navigates between deployments (the deployment-seq route), the value of @model changes but the structure of the template does not. As a result, Ember efficiently re-uses as much of the DOM and component tree as possible. This is good — it wouldn’t make sense to tear everything down only to recreate with slightly different data. However, it exposes various of our components which set up initial state when they’re constructed, but don’t recompute that state when new args appear. <OperationLogs> and <RenderTerminal> both have this issue, leading to the bug at the heart of this issue. Interestingly, <Section> also has a sticky state problem, but it’s harder to say what to do about <Section> because there isn’t a generic concept for when it should be “reset”.