Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

ui: 0.7 final UI clean up tasks #2883

Closed
11 of 14 tasks
Tracked by #2391 ...
sabrinako opened this issue Jan 6, 2022 · 6 comments · Fixed by #2898
Closed
11 of 14 tasks
Tracked by #2391 ...

ui: 0.7 final UI clean up tasks #2883

sabrinako opened this issue Jan 6, 2022 · 6 comments · Fixed by #2898
Labels
Milestone

Comments

@sabrinako
Copy link
Contributor

sabrinako commented Jan 6, 2022

TASKS (can add more if any are spotted besides the ones listed)

Merged

  • Clean up styling in dark mode (ensure all coloring looks correct)
  • Add additional space after the check mark icons of each line in timeline component
  • Fix breadcrumbs (seems like most of them except for deployments are off)
  • Page headers with icon are missing (build and release details pages)
@sabrinako sabrinako added the ui label Jan 6, 2022
@sabrinako sabrinako added this to the 0.7.0 milestone Jan 6, 2022
@sabrinako sabrinako mentioned this issue Jan 6, 2022
13 tasks
@almonk
Copy link
Contributor

almonk commented Jan 10, 2022

Page layout

  • Page headers with icon are missing
  • Alignment of overview and timeline panel are off, relative to each other (baseline of 'status' should match baseline of 'Build...' for e.g.. Adding the horizontal rules under the headers will help

Design:
CleanShot 2022-01-10 at 13 25 45@2x

Current implentation:
CleanShot 2022-01-10 at 13 25 51@2x


Sidebar

  • Remove minimum height constraint for rows
  • Secondary text is too close to top row and should be less prominent (e.g. below)

Desired:
CleanShot 2022-01-10 at 13 36 57@2x

Current implentation:
CleanShot 2022-01-10 at 13 33 05@2x


Timeline

  • Missing spacing between status icon and text

CleanShot 2022-01-10 at 13 38 27@2x


Overview

(In addition to existing issues highlighted...)

  • Commit information is misaligned horizontally with items above
  • Lets reduce the column width of all the titles – I used 100px as the new width and that looked much better
  • New handling for image titles (below)

CleanShot 2022-01-10 at 13 39 44@2x

For the image names, lets let flex take on the hard work of adding ellipsis when it's going to overflow and make the whole image name available on mouseover as a tooltip (or in the title)

Before and desired below;

123

@jgwhite
Copy link
Contributor

jgwhite commented Jan 12, 2022

  • Missing spacing in build status

CleanShot 2022-01-12 at 15 00 11@2x

@jgwhite
Copy link
Contributor

jgwhite commented Jan 12, 2022

  • Tight spacing between header and list on apps list page

CleanShot 2022-01-12 at 15 12 36@2x

@jgwhite
Copy link
Contributor

jgwhite commented Jan 12, 2022

  • Logs and Exec pages have headings but Deployments, Builds, and Releases pages do not

Perhaps none of these pages needing a heading anymore?

CleanShot 2022-01-12 at 15 31 14@2x

CleanShot 2022-01-12 at 15 31 02@2x

@jgwhite
Copy link
Contributor

jgwhite commented Jan 12, 2022

@almonk given that we don’t have commit messages available yet (nor are we always guaranteed to have them) what do you think about this heading in the deployment detail page?

CleanShot 2022-01-12 at 15 50 50@2x

@jgwhite
Copy link
Contributor

jgwhite commented Jan 12, 2022

  • Release status is missing some spacing and an icon

CleanShot 2022-01-12 at 15 58 18@2x

@sabrinako sabrinako mentioned this issue Jan 13, 2022
7 tasks
@sabrinako sabrinako linked a pull request Jan 13, 2022 that will close this issue
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants