This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
ui: Ensure <OperationLogs>
reacts correctly when @jobId
updates
#2901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgwhite
added
ui
pr/no-changelog
No automatic changelog entry required for this pull request
labels
Jan 13, 2022
Ember Asset Size actionAs of 6c6479f Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
jgwhite
force-pushed
the
ui/operation-logs-attr-change
branch
from
January 13, 2022 16:00
2dd62fa
to
82e98cf
Compare
@gregone you’ll see that for the |
jgwhite
force-pushed
the
ui/operation-logs-attr-change
branch
from
January 13, 2022 16:05
82e98cf
to
a18d1c7
Compare
gregone
reviewed
Jan 13, 2022
jgwhite
force-pushed
the
ui/operation-logs-attr-change
branch
from
January 13, 2022 16:06
a18d1c7
to
1fc6cd5
Compare
jgwhite
force-pushed
the
ui/operation-logs-attr-change
branch
from
January 13, 2022 16:36
0b0fd96
to
384678a
Compare
jgwhite
commented
Jan 13, 2022
gregone
approved these changes
Jan 13, 2022
jgwhite
force-pushed
the
ui/operation-logs-attr-change
branch
from
January 13, 2022 20:31
384678a
to
c8ce2cc
Compare
jgwhite
force-pushed
the
ui/operation-logs-attr-change
branch
from
January 13, 2022 21:17
c8ce2cc
to
f90f73d
Compare
jgwhite
force-pushed
the
ui/operation-logs-attr-change
branch
from
January 13, 2022 22:20
f90f73d
to
8b8f860
Compare
gregone
approved these changes
Jan 14, 2022
jgwhite
removed
the
pr/no-changelog
No automatic changelog entry required for this pull request
label
Jan 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why the change?
Closes #2855
What’s the plan?
<OperationLogs>
What does it look like?
Before
CleanShot.2022-01-13.at.23.16.12.mp4
After
CleanShot.2022-01-13.at.23.14.47.mp4
How do I test it?
git checkout ui/operation-logs-attr-change