Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

ui: Ensure <OperationLogs> reacts correctly when @jobId updates #2901

Merged
merged 5 commits into from Jan 14, 2022

Conversation

jgwhite
Copy link
Contributor

@jgwhite jgwhite commented Jan 13, 2022

Why the change?

Closes #2855

What’s the plan?

  • Figure out how to get current text from an xterm.js instance
  • Write a test for <OperationLogs>
  • Make the test pass
  • Make the xterm.js helper work on Linux (i.e. in CI)

What does it look like?

Before

CleanShot.2022-01-13.at.23.16.12.mp4

After

CleanShot.2022-01-13.at.23.14.47.mp4

How do I test it?

  1. Check out the branch git checkout ui/operation-logs-attr-change
  2. Boot the dev server against a waypoint server
  3. Try navigating between deployments
  4. Verify that the logs are correctly refreshed

@jgwhite jgwhite added ui pr/no-changelog No automatic changelog entry required for this pull request labels Jan 13, 2022
@jgwhite jgwhite added this to the 0.7.0 milestone Jan 13, 2022
@jgwhite jgwhite self-assigned this Jan 13, 2022
@github-actions
Copy link

github-actions bot commented Jan 13, 2022

Ember Asset Size action

As of 6c6479f

Files that got Bigger 🚨:

File raw gzip
waypoint.js +612 B +160 B

Files that stayed the same size 🤷‍:

File raw gzip
vendor.js 0 B 0 B
vendor.css 0 B 0 B
waypoint.css 0 B 0 B

@jgwhite
Copy link
Contributor Author

jgwhite commented Jan 13, 2022

@gregone you’ll see that for the getTerminalText helper I used a very literal-minded approach of simulating “select all”, then “copy”, then returning the resultant clipboard data. However, it looks like xterm.js only recognizes the Mac shortcut for select all (cmd+a) and doesn’t have anything special for Windows and Linux. I hope I’m wrong about this, but if not we might need a slightly different approach.

ui/app/components/operation-logs/index.hbs Show resolved Hide resolved
ui/tests/helpers/xterm.ts Outdated Show resolved Hide resolved
ui/tests/helpers/xterm.ts Outdated Show resolved Hide resolved
ui/tests/test-helper.js Outdated Show resolved Hide resolved
ui/tests/test-helper.js Outdated Show resolved Hide resolved
@jgwhite jgwhite force-pushed the ui/operation-logs-attr-change branch from f90f73d to 8b8f860 Compare January 13, 2022 22:20
@jgwhite jgwhite modified the milestones: 0.7.0, 0.7.x Jan 13, 2022
@jgwhite jgwhite marked this pull request as ready for review January 13, 2022 22:24
@jgwhite jgwhite requested a review from gregone January 13, 2022 22:24
@jgwhite jgwhite removed the pr/no-changelog No automatic changelog entry required for this pull request label Jan 14, 2022
@jgwhite jgwhite merged commit ffd3df4 into main Jan 14, 2022
@jgwhite jgwhite deleted the ui/operation-logs-attr-change branch January 14, 2022 11:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui: Logs don’t update when switching between deployments
2 participants