Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

Add more Helm options #3950

Merged
merged 3 commits into from Sep 30, 2022

Conversation

denysvitali
Copy link
Contributor

This PR adds support for the following new Helm options:

  • create_namespace
  • skip_crds

Copy link
Contributor

@paladin-devops paladin-devops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great @denysvitali! In addition to my feedback, I think we also need to generate the documentation for this PR's plugin changes. With our Makefile, you can run make gen/website-mdx to do that automatically. 😄 I've run into issues with generating the docs in the past myself as a contributor, but it works like a charm now! Let us know if you need a hand.

builtin/k8s/helm/platform.go Outdated Show resolved Hide resolved
builtin/k8s/helm/platform.go Show resolved Hide resolved
Copy link
Contributor

@paladin-devops paladin-devops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⛑️ 🎉 thanks @denysvitali!

@paladin-devops paladin-devops removed the backport/website Automerge PR into stable-website branch after merge to main label Sep 30, 2022
@paladin-devops paladin-devops merged commit 36a3934 into hashicorp:main Sep 30, 2022
@denysvitali denysvitali deleted the feature/more-helm-options branch October 4, 2022 08:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants