-
Notifications
You must be signed in to change notification settings - Fork 329
serverconfig: store platform in server config #1000
Conversation
Prior to this commit, waypoint had no way internally to figure out what kind of platform a server was, which meant it had to rely on the user to pass the proper flag when doing any server operations on an existing context. It also meant it was difficult to realize what a server platform was when looking at existing context through `waypoint context list`. This commit updates that to store the context passed in from install.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is good as-is. Is the plan to use this for upgrade
and uninstall
then to not require the -platform
flag?
@mitchellh - Yes! Eventually I think we can make it so that the platform flag won't be required for those commands, but we'll need users to use it at least for a while since old contexts won't have platform stored. |
Also I was thinking the upgrade/uninstall enhancement to use this can come after the initial PRs go through since it's separate. |
Yes definitely |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Prior to this commit, waypoint had no way internally to figure out what
kind of platform a server was, which meant it had to rely on the user to
pass the proper flag when doing any server operations on an existing
context. It also meant it was difficult to realize what a server
platform was when looking at existing context through
waypoint context list
. This commit updates that to store the context passed in frominstall.
For any previous context prior to this change, we will show
n/a
in thewaypoint context list
output since we did not store that context platform.Fixes #893