This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
internal/server/state: project put should not modify applications #1027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We document that project-related APIs cannot be used for applications, but previously we didn't preserve existing applications. If a user called UpsertProject to modify an existing project it'd blow away all their applications. This couldn't be hit in the real world unless the user was using the API directly, since `waypoint init -update` is the only thing that calls this API and it always registers applications again. But with future changes such as introducing server side waypoint.hcl and future UI changes to modify projects, this would've become a big issue.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We document that project-related APIs cannot be used for applications,
but previously we didn't preserve existing applications. If a user
called UpsertProject to modify an existing project it'd blow away all
their applications.
This couldn't be hit in the real world unless the user was using the API
directly, since
waypoint init -updateis the only thing that callsthis API and it always registers applications again.
But with future changes such as introducing server side waypoint.hcl and
future UI changes to modify projects, this would've become a big issue.