This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
internal/server: send entrypoint URL config only when we get a token #1040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the server level, this sets us up completely for any scenario where the URL service configuration changes. However, the CEB doesn't yet support changing URL configurations (it ignores them once it has initialized) so we only send down the URL config once we are ready. Future changes will just be ignored.
mitchellh
commented
Jan 29, 2021
| @@ -55,7 +55,7 @@ func (s *service) UpsertDeployment( | |||
| } | |||
|
|
|||
| // Create a context that will timeout relatively quickly | |||
| ctx, cancel := context.WithTimeout(ctx, 5*time.Second) | |||
| ctx, cancel := context.WithTimeout(ctx, 30*time.Second) | |||
There was a problem hiding this comment.
This is an unrelated change that we want to get in as well to increase the buffer horizon has to setup the hostname.
krantzinator
approved these changes
Jan 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the server level, this sets us up completely for any scenario where
the URL service configuration changes. However, the CEB doesn't yet
support changing URL configurations (it ignores them once it has
initialized) so we only send down the URL config once we are ready.
Future changes will just be ignored.