Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

builtin/docker: Add Binds, Labels and Networks config options #1065

Merged
merged 4 commits into from
Feb 8, 2021

Conversation

briancain
Copy link
Member

@briancain briancain commented Feb 8, 2021

This pull request introduces three new config options for the docker platform for deploys:

  • Labels
  • Networks
  • Binds

It allows users to label their deployed container, as well as connect additional networks.

Fixes #1064

This commit introduces a new config option to allow defining container
Labels as a map of key value pairs when deploying.
This commit introduces a config option to connect the deployed
application container to additional networks.
@prabirshrestha
Copy link

given that it seems small can we also have volume support? For example I would like to persist traefik certs in docker volume.

@briancain
Copy link
Member Author

briancain commented Feb 8, 2021

@prabirshrestha For sure, I've implemented that as Binds now. I think we'd want Volumes to match what the docker client supports, which ends up being a lot more config options. Binds should get us close for now and is the easiest path forward for users just wanting to share a folder to the container, and if it makes sense down the road we can use Volumes for more robust configuration.

@briancain briancain changed the title builtin/docker: Add Labels and Networks config options builtin/docker: Add Binds, Labels and Networks config options Feb 8, 2021
@briancain briancain merged commit 3186284 into main Feb 8, 2021
@briancain briancain deleted the f-docker-labels-networks branch February 8, 2021 22:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allowing adding label and network for docker deployment
4 participants