This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
rebase and fixup 693 #1082
Merged
rebase and fixup 693 #1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not all services require a load balancer, such as services are may run based upon events from other AWS services, process data from an S3 bucket, or be internal only (accessible from service discovery, for example). This option allows us to disable the creation of the load balancer.
This commit extracts the ALB creation process into a separate function so it's easy to conditionally create it whether the service is a backend service or not.
If the LoadBalancerArn and TargetGroupArn are not empty, then delete them before deleting the ECS service. I've extracted it to a separate function to make the conditional simpler.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rebased #693 and added a doc field for the additional config
closes #693