This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Polling Support #1109
Merged
Polling Support #1109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanphx
suggested changes
Feb 18, 2021
briancain
suggested changes
Feb 18, 2021
| } | ||
|
|
||
| // wait for deletion to complete | ||
| err = wait.PollImmediate(2*time.Second, 10*time.Minute, func() (bool, error) { |
There was a problem hiding this comment.
I've noticed we end up waiting 10 minutes for a lot of things in the k8s platform. Is this a reasonable amount of time? Is 5 minutes not enough?
There was a problem hiding this comment.
On Azure stuff like PVCs sometimes take that long. :|
internal/server: proto internal/server: proto changes to list by workspace internal/server: proto changes internal/server: proto changes
This stops the poll queuer.
Co-authored-by: Brian Cain <bcain@hashicorp.com>
mitchellh
commented
Feb 19, 2021
mitchellh
commented
Feb 19, 2021
mitchellh
commented
Feb 19, 2021
mitchellh
commented
Feb 19, 2021
evanphx
approved these changes
Feb 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces support for polling and triggering an
upon any changes in Git.The primary architecture of this is as follows: the
Projectstructure maintains the polling settings. New APIs were added to thestatepackage to grab the next project to poll that returns a deadline (when to poll). A new single goroutine poller is now started by the server which grabs that next project to poll, waits until the deadline, then queues a poll job. There is some watchset handling in there to detect the case that the project settings changes or projects were added/removed.Note, especially for @evanphx: I'm still unhappy with the datasource interface in general and still want to take a broad pass at that. For this PR, I just kind of forced in the interface functions required to make this work. This is all internal logic though and we only have one real implementation (Git) so I think we can fix this up later without affecting any users.
I expect this to have bugs and imperfections! I did my best to test various cases. This PR is primarily about laying the major minimum implementation for this feature.