WAYP-190 Add jobs and ui endpoints to gateway and re-gen json. #3355
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
teresamychu
force-pushed
the
update_proto_gateway_jobs_ui
branch
from
5903e79
to
cccfbac
Compare
.changelog/3355.txt
Outdated
| @@ -0,0 +1,4 @@ | |||
| ```release-note:improvement | |||
| core: update swagger and gateway yml to include jobs and ui endpoints. | |||
|
|
|||
There was a problem hiding this comment.
Hey! Noting that we typically reserve changelog entries for user facing bugs/features/improvements. This is more of a dev thing, so no need for a changelog 👍🏻
There was a problem hiding this comment.
OH ok! Hmmm i added this because the build was failing on the changelog check? Is there something I need to do to make it skip this step in the build?
There was a problem hiding this comment.
Yep! We run that check on all PRs, so you can opt out of it for ones that don't need it with pr/no-changelog.
There was a problem hiding this comment.
@teresamychu if it's a "no changelog" kind of PR, you can just add the pr/no-changelog label! 😄
There was a problem hiding this comment.
ooooo ok got it! I'll do that now and remove this file. Thanks guys!
teresamychu
force-pushed
the
update_proto_gateway_jobs_ui
branch
from
cccfbac
to
ddccfc8
Compare
teresamychu
added
the
pr/no-changelog
teresamychu
force-pushed
the
update_proto_gateway_jobs_ui
branch
from
ddccfc8
to
4f48aa0
Compare
There was a problem hiding this comment.
Looks good overall! Good selection of path-based routes on the list endpoint. For posterity, all permutations of the ListJobsRequest proto are possible through the gateway, even if they're not represented as path tokens - the other fields in the request proto can be passed through as query parameters.
Just one note on rerunning make gen/server
pkg/server/gen/server.swagger.json
Outdated
| ] | ||
| } | ||
| }, | ||
| "/waypoint/2022-02-03/namespace/*/ui/deployments/project/{application.project}": { |
There was a problem hiding this comment.
You'll want to re-run make gen/server to get the simplified paths from gateway.yml in here too.
There was a problem hiding this comment.
Ah right! Ok done!
teresamychu
force-pushed
the
update_proto_gateway_jobs_ui
branch
from
4f48aa0
to
cf1deaf
Compare
No description provided.