Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

Fix flakey ceb/ssh test #4651

Merged
merged 1 commit into from
May 3, 2023
Merged

Fix flakey ceb/ssh test #4651

merged 1 commit into from
May 3, 2023

Conversation

jgwhite
Copy link
Contributor

@jgwhite jgwhite commented May 3, 2023

Using require.Eventually rather than an immediate assertion.

@jgwhite
Fix flakey ceb/ssh test
c8fd9f5 
Using require.Eventually rather than an immediate assertion.
@jgwhite jgwhite requested a review from a team as a code owner May 3, 2023 15:23
@jgwhite jgwhite self-assigned this May 3, 2023
briancain
briancain approved these changes May 3, 2023
View reviewed changes
Copy link
Member

@briancain briancain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! 👍🏻

@briancain briancain added the pr/no-changelog No automatic changelog entry required for this pull request label May 3, 2023
@jgwhite jgwhite merged commit a875857 into main May 3, 2023
41 of 43 checks passed
@jgwhite jgwhite deleted the ceb-ssh-flake-fix branch May 3, 2023 15:43
@hc-github-team-waypoint hc-github-team-waypoint mentioned this pull request May 3, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@briancain briancain briancain approved these changes

Assignees

@jgwhite jgwhite

Labels
backport/0.11.x pr/no-changelog No automatic changelog entry required for this pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jgwhite @briancain