Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

Conversation

hc-github-team-waypoint
Copy link
Collaborator

Backport

This PR is auto-generated from #4660 to be assessed for backporting due to the inclusion of the label backport/0.11.x.

The below text is copied from the body of the original PR.


Prior to this commit, a user could create a bad HTTP path with a trigger name like ../bad. This commit fixes that behavior by validating the given trigger name matches our expected valid path tokens.

With this fix:

brian@ubuntu:waypoint-tetris λ waypoint trigger create -name=../hello -op=build                                                                        ±[main]
! trigger: (name: name cannot contain '../'.).

Overview of commits

@hc-github-team-waypoint hc-github-team-waypoint merged commit a9d624c into release/0.11.x May 3, 2023
@hc-github-team-waypoint hc-github-team-waypoint force-pushed the backport/maint/trigger/ensure-names-are-valid-paths/ultimately-allowed-mutt branch from b01b90d to 846e886 Compare May 3, 2023 21:19
@hc-github-team-waypoint hc-github-team-waypoint deleted the backport/maint/trigger/ensure-names-are-valid-paths/ultimately-allowed-mutt branch May 3, 2023 21:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant