This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Backport of server: Check that UserFromContext gets user before generating token into release/0.11.x #4683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-waypoint
force-pushed
the
backport/server/err-on-no-user-context/honestly-grand-mammoth
branch
from
03870d9
to
9fa863e
Compare
hc-github-team-waypoint
force-pushed
the
backport/server/err-on-no-user-context/honestly-grand-mammoth
branch
from
4369dc1
to
eb63ec1
Compare
hc-github-team-waypoint
deleted the
backport/server/err-on-no-user-context/honestly-grand-mammoth
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #4673 to be assessed for backporting due to the inclusion of the label backport/0.11.x.
The below text is copied from the body of the original PR.
Prior to this commit, the servers auth would not validate that a proper user was found for the given context prior to generating a token. We should not generate a token if no user was found, so this commit updates the login token func to return an unathenticated error if no user was found in the given context.
Fixes WAYP-1155
Overview of commits