This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Allow Nomad sentinel policy override on install #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickethier
suggested changes
Oct 22, 2020
| nomadRegionF string | ||
| nomadDatacentersF []string | ||
| nomadNamespaceF string | ||
| nomadPolicyOverrideF bool |
There was a problem hiding this comment.
You'll need to register the flag with the cli framework for it to be available. That can be done in the NomadFlags function at the end of this file.
There was a problem hiding this comment.
🤦 I knew I missed something. Thank you.
There was a problem hiding this comment.
@nickethier let me know if that's good
nickethier
approved these changes
Oct 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
waypoint server install ...there is no way to override Nomad sentinel policies. This allows a simple override flag to allow folks to get running as quickly as possible.