-
Notifications
You must be signed in to change notification settings - Fork 311
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove active record specific extensions as they are moved to hashie_…
…rails
- Loading branch information
1 parent
2c8d5d5
commit 7e66bdd
Showing
2 changed files
with
0 additions
and
28 deletions.
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7e66bdd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't get the idea. Hashie often used as internal dependency, so adding additional gem to fix this seems confusing.
7e66bdd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@etehtsea This has a lot of history. The choice was either for developers to write Ruby code or extract it into another gem. See #154 and feel free to pitch in. I decided for an external gem, it makes things clear - Hashie itself should not have any dependencies, even if implicit, much less Rails.