Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #202 by stopping method redefinition #206

Merged
merged 1 commit into from Aug 21, 2014

Conversation

michaelherold
Copy link
Member

The stack overflow was caused by recursively redefining #set_value_without_coercion in nested subclasses that include the Coercion extension. Checking to see if that method is already defined stops that issue from occurring.

@dblock
Copy link
Member

dblock commented Aug 20, 2014

@michaelherold is on a roll ... :)

dblock added a commit that referenced this pull request Aug 21, 2014
@dblock dblock merged commit 0598fcc into hashie:master Aug 21, 2014
@michaelherold michaelherold deleted the stack-overflow-in-coerce branch August 26, 2014 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants