Add block to Extensions::DeepMerge #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Galathius
force-pushed
the
add-block-to-deep-merge-extension
branch
2 times, most recently
from
28a5d82
to
8efa387
Compare
|
I like it. I think this needs to be documented in README, too. And fix the build, please. |
| @@ -6,6 +6,7 @@ | |||
| * [#252](https://github.com/intridia/hashie/pull/252): Add support for conditionally required Hashie::Dash attributes - [@ccashwell](https://github.com/ccashwell). | |||
| * [#256](https://github.com/intridia/hashie/pull/256): Inherit key coercions - [@Erol](https://github.com/Erol). | |||
| * [#259](https://github.com/intridia/hashie/pull/259): Fix handling of default proc values in Mash - [@Erol](https://github.com/Erol). | |||
| * [#260](https://github.com/intridia/hashie/pull/260): Add block to deep merge extension - [@galathius](https://github.com/galathius). | |||
There was a problem hiding this comment.
Be specific what "deep merge extension" is, Extensions::DeepMerge.
Galathius
force-pushed
the
add-block-to-deep-merge-extension
branch
3 times, most recently
from
471b1c1
to
056c7d9
Compare
Galathius
changed the title
Galathius
force-pushed
the
add-block-to-deep-merge-extension
branch
from
056c7d9
to
80191ce
Compare
Galathius
changed the title
|
This is good, but I still think it needs a README update. Also see my question above. |
Galathius
force-pushed
the
add-block-to-deep-merge-extension
branch
from
80191ce
to
861adf9
Compare
Galathius
force-pushed
the
add-block-to-deep-merge-extension
branch
from
861adf9
to
2846b3e
Compare
|
Merging this, looks great. |
dblock
added a commit
that referenced
this pull request
Dec 30, 2014
Add block to Extensions::DeepMerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like a Rails hashes #deep_merge - http://apidock.com/rails/Hash/deep_merge