Fix: NameError (uninitialized constant Hashie::Extensions::Parsers::YamlErbParser::Pathname)

[onk]

Hashie::Mash.load require Pathname since v3.4.5.

see: bbafade

irb(main):001:0> require "hashie"
=> true
irb(main):002:0> Hashie::Mash.load("foo.yml")
Traceback (most recent call last):
        6: from /opt/rubies/2.6.0-dev/bin/irb:11:in `<main>'
        5: from (irb):2
        4: from /Users/onaka/.gem/ruby/2.6.0/gems/hashie-3.5.7/lib/hashie/mash.rb:105:in `load'
        3: from /Users/onaka/.gem/ruby/2.6.0/gems/hashie-3.5.7/lib/hashie/extensions/parsers/yaml_erb_parser.rb:19:in `perform'
        2: from /Users/onaka/.gem/ruby/2.6.0/gems/hashie-3.5.7/lib/hashie/extensions/parsers/yaml_erb_parser.rb:19:in `new'
        1: from /Users/onaka/.gem/ruby/2.6.0/gems/hashie-3.5.7/lib/hashie/extensions/parsers/yaml_erb_parser.rb:9:in `initialize'
NameError (uninitialized constant Hashie::Extensions::Parsers::YamlErbParser::Pathname)
irb(main):003:0> require "pathname"
=> true
irb(main):004:0> Hashie::Mash.load("foo.yml")
=> #<Hashie::Mash bar="baz">

[dblock]

This needs a test, please. If you cannot repro in a regular spec, you can always make an integration one.

[dblock]

You should list the problem here, so "Fix: NameError (uninitialized constant Hashie::Extensions::Parsers::YamlErbParser::Pathname) in Mashie::Mash.load" instead of saying what the fix was, to help people with the same problem know that it was fixed.

[onk]

This problem cannot be reproduced using bundler.
https://github.com/bundler/bundler/blob/v1.16.1/lib/bundler.rb#L6

It can be reproduced with the code below, but I think this is too technical.

Object.send(:remove_const, :Pathname)
$LOADED_FEATURES.reject! { |f| f.include?('/pathname') }

require 'pathname' #=> true

I would like to skip the repro test. WDYT?

[michaelherold]

You're right: Bundler requires pathname, so it's not easy to write a failing test within our test harness. Here's a reproduction script that I came up with:

$LOAD_PATH.unshift('lib')

require 'tmpdir'
require 'hashie'

def within_temporary_directory
  Dir.mktmpdir.tap do |dir|
    Dir.chdir(dir) do
      yield if block_given?
    end
  end
end

within_temporary_directory do
  File.write('foo.yml', 'foo: bar')
  Hashie::Mash.load('foo.yml')
end

#=> /Users/michael/.gem/ruby/2.4.2/gems/hashie-3.5.7/lib/hashie/extensions/parsers/yaml_erb_parser.rb:9:in `initialize': uninitialized constant Hashie::Extensions::Parsers::YamlErbParser::Pathname (NameError)
#=>         from /Users/michael/.gem/ruby/2.4.2/gems/hashie-3.5.7/lib/hashie/extensions/parsers/yaml_erb_parser.rb:19:in `new'
#=>         from /Users/michael/.gem/ruby/2.4.2/gems/hashie-3.5.7/lib/hashie/extensions/parsers/yaml_erb_parser.rb:19:in `perform'
#=>         from /Users/michael/.gem/ruby/2.4.2/gems/hashie-3.5.7/lib/hashie/mash.rb:105:in `load'
#=>         from test.rb:16:in `block in <main>'
#=>         from test.rb:9:in `block (2 levels) in within_temporary_directory'
#=>         from test.rb:8:in `chdir'
#=>         from test.rb:8:in `block in within_temporary_directory'
#=>         from test.rb:7:in `tap'
#=>         from test.rb:7:in `within_temporary_directory'
#=>         from test.rb:14:in `<main>'

I think the fix is the correct one (albeit with a missing empty line between the require and the class definition, but that can be fixed during the merge). I also think I'm good with adding the change without a test given the nature of the bug. What do you think, @dblock?

[dblock]

Lets put back an empty line after this?

[dblock]

OK, this looks good, rebase and lets merge? Thanks.

[onk]

Fixed the blank line and rebased. Thanks.

[michaelherold]

Thanks for the contribution!