Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make explicit the reference to standard Hash #49

Closed
wants to merge 1 commit into from
Closed

Make explicit the reference to standard Hash #49

wants to merge 1 commit into from

Conversation

orend
Copy link

@orend orend commented Jun 6, 2012

the old version defines a new class called Hash inside the hashie module in the following manner: "class Hash < Hash". This is fine, and the second Hash there refers to ruby's Hash, but if for some reason the class is being reloaded it produces a superclass mismatch error. Defining the class like this: "class Hash < ::Hash" disambiguates Hash and allows this code to be reloaded multiple times.

Thanks to @meh who made a similar commit to master - but it's needed in the stable branch (and a new release is needed as well)

@jch
Copy link
Contributor

jch commented Feb 12, 2013

Going through and cleaning up issues and pulls. I'll release this with 1.3.0 along with several other changes, but I won't be cutting another 1.1.x release. Thanks for the heads up.

@jch jch closed this Feb 12, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants